Feature/19 gspc admin page #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature/19-gspc-admin-page
felder101
requested changes
Mar 6, 2024
.env_example
Outdated
| @@ -60,7 +60,7 @@ DB_URI="postgres://postgres:postgres@localhost:5432/postgres" | |||
| # | |||
| # Deployment TL;DR: Set this in the app's environment variables. | |||
|
|
|||
| BASE_URL="https://training.smartpay.gsa.gov" | |||
| BASE_URL="http://localhost:3000" | |||
There was a problem hiding this comment.
Believe this can be reverted as it list to update in the deploy instructions in the readme.
| @@ -33,7 +33,7 @@ const pageTitle = "Admin Panel"; | |||
| </div> | |||
| </div> | |||
| </li> | |||
| <li class="usa-card tablet:grid-col-6"> | |||
| <!-- <li class="usa-card tablet:grid-col-6"> | |||
There was a problem hiding this comment.
Should this be commented out? How will the admin access the page?
There was a problem hiding this comment.
They want it removed for this deployment
| async def gspc_admin_invite( | ||
| gspcInvite: GspcInvite, | ||
| repo: GspcInviteRepository = Depends(gspc_invite_repository), | ||
| user=Depends(RequireRole(["Admin"])) |
There was a problem hiding this comment.
I think you are missing the Authorization header in the request on the vue component. Can you check to see if the user authorization is happening?
There was a problem hiding this comment.
Added, nice spot. I still need dataset for my local to get the admin role
training/schemas/gspc_invite.py
Outdated
| raise ValueError("Certification expiration date cannot be in the past") | ||
| return value | ||
|
|
||
| # def __init__(self, email_addresses, certification_expiration_date): |
There was a problem hiding this comment.
Please remove commented out code.
felder101
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19