Gsa/production release #731
Conversation
| setError(error) | ||
| } | ||
|
|
||
| isLoading.value = false |
There was a problem hiding this comment.
maybe isLoading and showSpinner reset can be in finally block instead to ensure isLoading and showSpinner are reset even exception happending?
There was a problem hiding this comment.
Added reset of isLoading and showSpinner boolean values in a finally block
| {value: 'Travel Training for Card/Account Holders and Approving Officials', label: 'Travel Training for Card/Account Holders and Approving Officials'}, | ||
| ]; | ||
|
|
||
| const v_all_info$ = useVuelidate(validation_info, user_input) |
There was a problem hiding this comment.
useVuelidate by default probably can't handle completation_date_range date compare, maybe helpers also need to be imported to add customized date validation to handle start date greater than end date issue. Currently, if I put start date greater than end date and hit submit, it display "please ender a valid date" for end date, which is not correct, as "01/11/2022" is valid date.
|
@felder101 the finally block looks good to me, just double check if submit button disable /enable function as expected, for completion date range comparison error one, would you mind discussing with @johnbeallgsa to see if this error handling part change will go to this release or create a backlog item and arrange the fix at later sprint? If new backlog item is created and scheduled for later sprint, I can approve this PR. Please let me know, thank you! |
|
@weiwang-gsa @felder101 I made a ticket #734 for this to be fixed in a later Sprint. |
There was a problem hiding this comment.
changes looks good to me, the date comparison issue is logged in ticket #734 for this to be fixed in a later Sprint.
Sprint 46 issues included:
BUG: Admin/User Profile Saved Changes are Not Displayed on Results screen #709
BUG: Insert a space between the date field of Completion date range end and Quiz type(s) on the SmartPay Training Report #705 Customizable Training Report for A/OPC #633