Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove weak turbine cutoff #3739

Merged
merged 2 commits into from
Jan 10, 2025
Merged

remove weak turbine cutoff #3739

merged 2 commits into from
Jan 10, 2025

Conversation

Glease
Copy link
Contributor

@Glease Glease commented Jan 1, 2025 •
edited
Loading

@Glease Glease requested a review from a team January 1, 2025 13:33
@Dream-Master Dream-Master added the bug fix Fix a bug. Please link it in the PR. label Jan 1, 2025
@Dream-Master
Copy link
Member

this change will crash the game with null input items
image
image

@Dream-Master
Copy link
Member

image

@Dream-Master
Copy link
Member

Guess this early game turbines was added for the pollution scrubber (single block)

@Dream-Master
Copy link
Member

image
found alks turbine. MAybe the bronze one is below 25k dura and is cut off. So i can remove the recipe in code mod

@Dream-Master
Copy link
Member

Dream-Master commented Jan 1, 2025 •
edited
Loading

@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 4, 2025
@Dream-Master
Copy link
Member

@serenibyss can we merge this and make a new pr for the other stuff?

@Glease
Copy link
Contributor Author

Glease commented Jan 10, 2025

@serenibyss @Dream-Master What exactly was the discussion?

@Dream-Master
Copy link
Member

maybe we can remove the threshold and remove th egt++ turbine blades that can crafted only in crafting table in another pr.

@Glease Glease force-pushed the feature/weak-turbine branch from a154373 to a747e37 Compare January 10, 2025 19:21
@Glease Glease changed the title change how weak turbines are handled remove weak turbine cutoff Jan 10, 2025
@Glease Glease requested a review from serenibyss January 10, 2025 19:21
@github-actions GitHub Actions
Copy link
Contributor

Warning: 2 uncommitted changes
pull request create failed: GraphQL: Head sha can't be blank, Base sha can't be blank, Head repository can't be blank, No commits between GTNewHorizons:feature/weak-turbine and origin:GTNewHorizons-feature/weak-turbine-spotless-fixes, Head ref must be a branch, not all refs are readable (createPullRequest)

@serenibyss serenibyss enabled auto-merge (squash) January 10, 2025 22:19
@serenibyss serenibyss merged commit 443acc6 into master Jan 10, 2025
5 checks passed
@serenibyss serenibyss deleted the feature/weak-turbine branch January 10, 2025 22:26
@Dream-Master Dream-Master removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serenibyss serenibyss serenibyss approved these changes

Assignees
No one assigned
Labels
bug fix Fix a bug. Please link it in the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove recipes of turbine blades that can't be crafted into a turbine
3 participants
@Glease @Dream-Master @serenibyss