Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtag for generating multi-plates #3821

Merged
merged 4 commits into from
Jan 19, 2025
Merged

Conversation

StaffiX
Copy link
Contributor

@StaffiX StaffiX commented Jan 18, 2025

Adds a subtag to generate double, triple, quadruple and quintuple plates, and adds the currently used materials to this tag

@serenibyss
Copy link
Member

serenibyss commented Jan 18, 2025

@Dream-Master I didn't approve any of these yet since I want your approval on the removal, but in terms of the actual code changes:

Review status:

@Dream-Master
Copy link
Member

Why we simplifying everything so much ? Why we not just generate quadruple and quintuple plates from this material we use ?

If you feel we need so rip off everything the quadrupple should stay. I don’t like we change the recipes because we rip off everything . We put out so much gt lost his soul some day

@Caedis
Copy link
Member

Caedis commented Jan 18, 2025

I believe the main reason is due to all versions of the plates being generated when only a couple have uses, just like tiny/small dusts

@boubou19
Copy link
Member

boubou19 commented Jan 18, 2025

Why we simplifying everything so much ? Why we not just generate quadruple and quintuple plates from this material we use ?

If you feel we need so rip off everything the quadrupple should stay. I don’t like we change the recipes because we rip off everything . We put out so much gt lost his soul some day

GT is way more than this, it's the spirit of big crafts and automation. I wouldn't be worried about losing its identity.
The issue with those items is that compared to tiny/small piles where we can just use some and trash the others because they serve as fractions of the dust and can be useful to balance some dust costs or chemical reactions, those items serve no purpose, as they are never used in ways that it would allow to put more than a stack of ingot worth of material. So the cons for them are:

  • NEI bloat
  • booting time spent on autogeneration for most of the bloat
  • they have no gameplay impact, they are crafting items, among others

pros:

  • item diversity in the recipe. Item diversity in recipes is cool because it forbids you to feel you are doing always the same kind of pattern automation.

I think it might be time to revisit the impacted recipes to keep item diversity without those generic ingots. Or we we register only the variants we use. Your call, i don't mind either.

Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked to Dream and he said he wants to have the used parts still generated and remove the rest

@StaffiX StaffiX changed the title Remove Quadruple and Quintuple Plates Add subtag for generating multi-plates Jan 19, 2025
@serenibyss serenibyss enabled auto-merge (squash) January 19, 2025 18:01
@serenibyss serenibyss merged commit 029e21d into GTNewHorizons:master Jan 19, 2025
5 checks passed
@StaffiX StaffiX deleted the plate branch January 20, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor For PRs rewritting a part of the code to have a nicer code overall.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants