Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Precise Assembler cannot accept UEV+ machine blocks. #3844

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Apeiria01
Copy link
Contributor

This is a hard-coded temporary fix, we might need a method (likely to be placed in util?) to retrieve all xxV machine blocks, exclude those wiered blocks like Bronze Plated Bricks with same java type but different meta.
I guess other MTE s like ExxonMobil also suffer from accepting wired blocks instead of accept only XXv machine blocks as expected.

Apeiria01 and others added 4 commits January 21, 2025 03:00
…other than ?V Machine Casing. Should retrieve fields from CoreMod to support UEV+ Machine Casing
Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change would be nice to make eventually, but currently some of these later casings would allow quite cheap tier skips, since for example UEV machine casing is only Bedrockium, and UIV machine casing is only Black Plutonium, allowing you to cheaply bypass more expensive casings like the UHV machine casing which is made out of Neutronium

@Apeiria01
Copy link
Contributor Author

image
While you can use some cheaper machine blocks, you still have to place energy hatches that matches the recipe. So at least accepting UEV+ blocks shall not let you bypass the voltage limit of assembler recipes.

@FourIsTheNumber
Copy link
Contributor

image While you can use some cheaper machine blocks, you still have to place energy hatches that matches the recipe. So at least accepting UEV+ blocks shall not let you bypass the voltage limit of assembler recipes.

It's not about bypassing the voltage limit, it's that you could use UEV or UIV hull as cheaper casings in a UHV prass with a UHV energy hatch.

@Apeiria01
Copy link
Contributor Author

Maybe we should correct the description to indicate that PreciseAssembler accepts UHV- machine blocks, not all machine blocks?

@Apeiria01
Copy link
Contributor Author

I think another feasible solution is to add another machine structure check to ensure machine block's tier <= energy hatch tier? So that the machine would report an incomplete structure if you are using UEV+ machine block but dont have UEV+ energy hatches

@Apeiria01
Copy link
Contributor Author

image
Now we have to place energy hatches with tier >= machine blocks

@serenibyss
Copy link
Member

@Apeiria01 Thank you for the effort, though I think simply updating the tooltip to reflect that only UHV and below is allowed currently would be a better approach for now. Eventually once these casings have more proper recipes, I think PrAss should allow these casings, at which point a change like this would be no longer necessary either. And for currently, I think this change is a bit unintuitive and could break bases unnecessarily

@serenibyss serenibyss added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants