-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Precise Assembler cannot accept UEV+ machine blocks. #3844
base: master
Are you sure you want to change the base?
Conversation
…other than ?V Machine Casing. Should retrieve fields from CoreMod to support UEV+ Machine Casing
# Conflicts: # dependencies.gradle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change would be nice to make eventually, but currently some of these later casings would allow quite cheap tier skips, since for example UEV machine casing is only Bedrockium, and UIV machine casing is only Black Plutonium, allowing you to cheaply bypass more expensive casings like the UHV machine casing which is made out of Neutronium
Maybe we should correct the description to indicate that PreciseAssembler accepts UHV- machine blocks, not all machine blocks? |
I think another feasible solution is to add another machine structure check to ensure machine block's tier <= energy hatch tier? So that the machine would report an incomplete structure if you are using UEV+ machine block but dont have UEV+ energy hatches |
@Apeiria01 Thank you for the effort, though I think simply updating the tooltip to reflect that only UHV and below is allowed currently would be a better approach for now. Eventually once these casings have more proper recipes, I think PrAss should allow these casings, at which point a change like this would be no longer necessary either. And for currently, I think this change is a bit unintuitive and could break bases unnecessarily |
This is a hard-coded temporary fix, we might need a method (likely to be placed in util?) to retrieve all xxV machine blocks, exclude those wiered blocks like Bronze Plated Bricks with same java type but different meta.
I guess other MTE s like ExxonMobil also suffer from accepting wired blocks instead of accept only XXv machine blocks as expected.