Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix black hole circuits #3845

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Fix black hole circuits #3845

merged 6 commits into from
Jan 21, 2025

Conversation

FourIsTheNumber
Copy link
Contributor

@FourIsTheNumber FourIsTheNumber commented Jan 21, 2025 •
edited
Loading

Black hole was not properly distinguishing circuits due to a few errors.

  • Input separation is now forced on. Disabling this makes no sense with a circuit mode mechanic
  • Use -1 as the "not found" mode number instead of 0, which was overlapping with compressor mode
  • Reset the cached previous recipe if the recipe is in a different circuit, since this cache was bypassing the circuit check
  • Bonus: fix a small typo in superstable seed

@FourIsTheNumber FourIsTheNumber added the bug fix Fix a bug. Please link it in the PR. label Jan 21, 2025
@serenibyss serenibyss enabled auto-merge (squash) January 21, 2025 21:53
@MeiTianyou
Copy link
Contributor

i love it boss

@serenibyss serenibyss merged commit f048206 into master Jan 21, 2025
5 checks passed
@serenibyss serenibyss deleted the fix-bhc-circuits branch January 21, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeiTianyou MeiTianyou MeiTianyou approved these changes

@serenibyss serenibyss serenibyss approved these changes

Assignees
No one assigned
Labels
bug fix Fix a bug. Please link it in the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FourIsTheNumber @MeiTianyou @serenibyss