Cover refactor, part 1 #3874
Merged
Cover refactor, part 1 #3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannickMG
added
the
refactor
YannickMG
force-pushed
the
cover-refactor
branch
from
39bd18f to
cc2b16c
Compare
|
This is a draft, I'll request a review when it's ready but comments are welcome of course. |
…, and CoverRedstoneTransmitterExternal is not incompatible with it.
YannickMG
force-pushed
the
cover-refactor
branch
from
4adef60 to
d67db37
Compare
The intent is to limit convoluted chained calls. If you want information about the cover, ask the CoverInfo. Usually you don't need the data, you want to call some other method on it.
YannickMG
force-pushed
the
cover-refactor
branch
from
d67db37 to
dfe83c6
Compare
The intent is to limit convoluted chained calls. If you want information about the cover, ask the CoverInfo. Usually you don't need the data, you want to call some other method on it.
miozune
reviewed
Feb 2, 2025
YannickMG
force-pushed
the
cover-refactor
branch
from
38831ab to
b49f343
Compare
miozune
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this refactor is to make CoverBehavior an implementation detail, so that we may eventually fold all of the cover "class stack" into CoverInfo and it's future subclasses.
Even if we don't every call to CoverBehavior requires information that CoverInfo has.... Just call the method through CoverInfo instead.
I want to make more refactors but the current changes are fine to merge as-is.