Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic LoreHolder Discovery #101

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Conversation

glowredman
Copy link
Member

Improves the LoreHolder system by identifying all fields during construction using FML's ASMDataTable. Previously, all classes containing one or more fields annotated with @LoreHolder would have been registered manually using LoreHandler.registerLoreHolder().

@glowredman glowredman requested a review from a team January 14, 2025 01:05
Copy link
Contributor

Warning: 2 uncommitted changes
pull request create failed: GraphQL: Head sha can't be blank, Base sha can't be blank, Head repository can't be blank, No commits between GTNewHorizons:auto-loreholder-discovery and origin:GTNewHorizons-auto-loreholder-discovery-spotless-fixes, Head ref must be a branch, not all refs are readable (createPullRequest)

@serenibyss serenibyss merged commit 3fb62c5 into master Jan 14, 2025
1 check passed
@serenibyss serenibyss deleted the auto-loreholder-discovery branch January 14, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants