ModDetectedDefault config annotation #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with MouseTweaks with GT5U loaded. Default for WheelTweak is true, but tested if gregtech is loaded, it was false as expected. |
|
TODO:
|
mitchej123
reviewed
Feb 11, 2024
| .map(Config.DefaultFloat::value).orElse(boxed ? (Float) field.get(null) : field.getFloat(null)); | ||
| if (field.isAnnotationPresent(Config.ModDetectedDefault.class)) { |
There was a problem hiding this comment.
This seems repeated amongst all of the cases - would be nice to turn it into a function/class helper that could be used in the chain above...
mitchej123
reviewed
Feb 11, 2024
| val newDefault = Optional.ofNullable(field.getAnnotation(Config.ModDetectedDefault.class)) | ||
| .map(f -> { | ||
| if (!f.coremod().isEmpty()) { | ||
| try { |
There was a problem hiding this comment.
I'd think caching these in a fastutils 2Boolean would be a good idea
|
Warning: 2 uncommitted changes |
Co-authored-by: GitHub GTNH Actions <>
|
Closing for now, will probably be rewritten if its still needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.