merge iih + mt hand command in one #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
glowredman
reviewed
Oct 21, 2024
There was a problem hiding this comment.
One enhancement could be to use ChatComponents such that, when clicking on any of the values, that values is copied to the clipboard. The current behaviour (MT snippet being copied to clipboard) should remain though.
In any case, this is a practical addition and long overdue.
src/main/java/com/gtnewhorizon/gtnhlib/commands/ItemInHandCommand.java
Outdated
Show resolved
Hide resolved
glowredman
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and move it to GTNHlib so that it's available from every dev environement when using client 17
related pr : GTNewHorizons/NewHorizonsCoreMod#1051