Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block/meta and item/meta pair classes #98

Merged
merged 12 commits into from
Jan 9, 2025
Merged

Conversation

RecursivePineapple
Copy link
Contributor

This PR adds a few util classes that I've needed several times in different mods. I've also seen similar classes replicated a good amount of times, so I figure these should be formalized properly.

If the mutability contract isn't clear, let me know. I tried to make it as robust as possible.

@RecursivePineapple RecursivePineapple requested a review from a team January 7, 2025 05:30
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Warning: 2 uncommitted changes
#99

@Dream-Master Dream-Master requested a review from a team January 7, 2025 20:22
@YannickMG YannickMG self-requested a review January 8, 2025 20:56
Copy link

@YannickMG YannickMG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final nitpick : the contract description on the mutable versions kind of makes it sound like there's an immutable implementation class which you could use instead. Maybe clarify that you meant the exposed type and not the implementation used.

@Dream-Master Dream-Master merged commit 3580876 into master Jan 9, 2025
1 check passed
@Dream-Master Dream-Master deleted the block-item-pairs branch January 9, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants