-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block/meta and item/meta pair classes #98
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannickMG
reviewed
Jan 7, 2025
src/main/java/com/gtnewhorizon/gtnhlib/eventbus/AutoEventBus.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gtnewhorizon/gtnhlib/util/data/BlockMeta.java
Outdated
Show resolved
Hide resolved
Warning: 2 uncommitted changes |
YannickMG
reviewed
Jan 7, 2025
src/main/java/com/gtnewhorizon/gtnhlib/util/data/LazyBlock.java
Outdated
Show resolved
Hide resolved
YannickMG
reviewed
Jan 7, 2025
src/main/java/com/gtnewhorizon/gtnhlib/util/data/BlockMeta.java
Outdated
Show resolved
Hide resolved
YannickMG
reviewed
Jan 8, 2025
src/main/java/com/gtnewhorizon/gtnhlib/util/data/BlockMeta.java
Outdated
Show resolved
Hide resolved
YannickMG
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final nitpick : the contract description on the mutable versions kind of makes it sound like there's an immutable implementation class which you could use instead. Maybe clarify that you meant the exposed type and not the implementation used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few util classes that I've needed several times in different mods. I've also seen similar classes replicated a good amount of times, so I figure these should be formalized properly.
If the mutability contract isn't clear, let me know. I tried to make it as robust as possible.