Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backhand support #53

Merged
merged 2 commits into from
Jan 18, 2025
Merged

Backhand support #53

merged 2 commits into from
Jan 18, 2025

Conversation

Caedis
Copy link
Member

@Caedis Caedis commented Jan 18, 2025

Also added a string formatter for the stack sizes

@Caedis Caedis requested review from Lyfts and 0hwx January 18, 2025 12:31
@slprime
Copy link
Member

slprime commented Jan 18, 2025

Maybee better use ReadableNumberConverter form NEI or AE2 insted McUtils.format?


I didn't delve into the code and why you need an item render, but you didn't think to use a render from NEI (GuiContainerManager.drawItem)? It can apply number formatting and also change font size dynamically if needed for you.

Example
image

@slprime
Copy link
Member

slprime commented Jan 18, 2025

@Caedis ^

@Caedis
Copy link
Member Author

Caedis commented Jan 18, 2025

Didnt think to hook into NEI for that

@Caedis
Copy link
Member Author

Caedis commented Jan 18, 2025

Dream, no merging this for now

@Caedis Caedis merged commit bd8631c into master Jan 18, 2025
1 check passed
@Caedis Caedis deleted the backhandCompat branch January 18, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants