Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LCR AssemblerRecipes. #751

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Add LCR AssemblerRecipes. #751

merged 5 commits into from
Nov 13, 2023

Conversation

DarkAhri
Copy link
Contributor

@DarkAhri DarkAhri commented Nov 4, 2023

Add LCR AssemblerRecipes.

@Dream-Master
Copy link
Member

@DarkAhri thanks for your pr but can you explain what recipe you add?

@Dream-Master
Copy link
Member

your build fail. can you run spotless?

@DarkAhri
Copy link
Contributor Author

DarkAhri commented Nov 4, 2023

@DarkAhri thanks for your pr but can you explain what recipe you add?

Adds assembler recipes to the LCR controller blocks.

@chochem
Copy link
Member

chochem commented Nov 4, 2023

as there is no circuit, did you check for conflicts?

@DarkAhri
Copy link
Contributor Author

DarkAhri commented Nov 5, 2023

as there is no circuit, did you check for conflicts?

there's no confilct, but adding circuit is a good idea.

@Dream-Master Dream-Master requested a review from a team November 5, 2023 11:36
@Dream-Master
Copy link
Member

@DarkAhri are you add the circuit to the recipe ?

@Dream-Master Dream-Master enabled auto-merge (rebase) November 13, 2023 08:55
@Dream-Master Dream-Master merged commit 4fb9dcc into GTNewHorizons:master Nov 13, 2023
1 check passed
@DarkAhri DarkAhri deleted the patch-1 branch December 8, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants