Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add realwingame gui #778

Closed
wants to merge 13 commits into from

Conversation

lordIcocain
Copy link
Contributor

@lordIcocain lordIcocain commented Dec 12, 2023

@vovaksenov
Copy link

vovaksenov commented Dec 12, 2023

Not sure where you got this list, but it might contain inaccuracies. Prometheus0000 im pretty sure is a dev/staff, not a contributor for example.

@Connor-Colenso Connor-Colenso added the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Dec 12, 2023
@lordIcocain
Copy link
Contributor Author

Not sure where you got this list, but it might contain inaccuracies. Prometheus0000 im pretty sure is a dev/staff, not a contributor for example.

my dev source is discord rolemembers role GTNH Devs and GT:NH Dev on Hiatu, so yeah mb have error jsut because i dont know all dev ppl

@vovaksenov
Copy link

vovaksenov commented Dec 12, 2023

I think you forgot the roles gtnh staff and staff on sabbatical. They are basically devs too afaik

@S4mpsa
Copy link
Contributor

S4mpsa commented Dec 12, 2023

When does this play? If it's after you go through the end portal, it's way too premature. HV is barely earlygame.

Should really play after you make your first Eye of Harmony (or go through the stargate but that might be a little hard to achieve for most people)

@Ultraxite
Copy link

some comments:

"enjoyable" thing at the end feels a bit esoteric and goofy for such a heartfelt, serious credits sequence. it should probs be "Gregtech
New Horizons"
where the New Horizons does the remaining thing like "enjoyable" does

I think there needs to be a shoutout/description part talking about GregoriusT and GregTech 5. Without them, this pack wouldnt exist.

Maybe also a few lines in that "now that youve beat the pack, good luck in other packs" section talking about how you've come full circle and can/should now contribute to development!

it could be cool to also have some screenshots breaking up each section of some cool loading-screen-art style shots of bases, especially endgame ones. Maybe even get some concept art or something from the devs - old videogame credits loved doing concept art/demo models etc.

@vovaksenov
Copy link

I think the text is a placeholder. It looks ai generated

@OneEyeMaker
Copy link
Contributor

I think there should be at least 2 different screens of such kind for different events.

  1. Firstly, screen that replaces vanilla one (after killing End dragon). Purpose of this screen should be "wish for good luck" for players reaches first early-game milestones.
  2. Secondly, screen with content demonstrated in video. And this one should be shown only for most dedicated players who reached some endgame goal. (EoHoho?/StarGate?)

@lordIcocain
Copy link
Contributor Author

When does this play? If it's after you go through the end portal, it's way too premature. HV is barely earlygame.

Should really play after you make your first Eye of Harmony (or go through the stargate but that might be a little hard to achieve for most people)

My idea was play when you first time go in stargate, but then I found out that official servers using gate... I think mb just add check if player have completed stargate quest.

@lordIcocain
Copy link
Contributor Author

I think the text is a placeholder. It looks ai generated

yeah, i used chatgpt. I couldn't even write a sentence haha. So if someone want write better text i would be so happy.

@lordIcocain
Copy link
Contributor Author

I think there should be at least 2 different screens of such kind for different events.

  1. Firstly, screen that replaces vanilla one (after killing End dragon). Purpose of this screen should be "wish for good luck" for players reaches first early-game milestones.
  2. Secondly, screen with content demonstrated in video. And this one should be shown only for most dedicated players who reached some endgame goal. (EoHoho?/StarGate?)

I think first one require change original mc code. if its possible would be cool. like a ask "did you think its end? ahaha"

@vovaksenov
Copy link

I think that the stargate end screen should start if you click on the stargate trophy. It would allow people to replay the credits if they want and add a cool function to the newly added trophy.

@Ultraxite
Copy link

Ultraxite commented Dec 12, 2023

yeah, i used chatgpt. I couldn't even write a sentence haha. So if someone want write better text i would be so happy.

it definitely reads like its saying a whole lot of nothing, very typical of AI writing models. I'd be happy to give it a shot at some point if nobody else does it. Dont blame you though, it can be hard if english isnt your first language

@Dream-Master Dream-Master removed the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Dec 18, 2023
@Dream-Master Dream-Master requested a review from a team December 18, 2023 11:35
@Connor-Colenso
Copy link
Contributor

Staff shouldn't be lumped in with devs, some staff don't dev at all. It should be a distinct category under admins.

@Dream-Master
Copy link
Member

@lordIcocain

@Dream-Master
Copy link
Member

@lordIcocain any news here ?

@lordIcocain
Copy link
Contributor Author

Nope

@IcaroKaue
Copy link

IcaroKaue commented Mar 3, 2024

I wrote a new text for it, if anyone wants to take a look. -> https://pastebin.com/2Kh7Pb5D

If it gets accepted I'll translate it into Portuguese.

@IcaroKaue
Copy link

I think there should be at least 2 different screens of such kind for different events.

  1. Firstly, screen that replaces vanilla one (after killing End dragon). Purpose of this screen should be "wish for good luck" for players reaches first early-game milestones.
  2. Secondly, screen with content demonstrated in video. And this one should be shown only for most dedicated players who reached some endgame goal. (EoHoho?/StarGate?)

I think first one require change original mc code. if its possible would be cool. like a ask "did you think its end? ahaha"

@lordIcocain According to the MC Wiki you only need to change "assets/minecraft/texts/end.txt". I think a txloader file would work. (We can change the credits and quote too, maybe adding the devs and such 😀)

@Dream-Master Dream-Master added the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Mar 11, 2024
@Dream-Master Dream-Master removed the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Apr 28, 2024
@Dream-Master
Copy link
Member

@lordIcocain any news here?

@boubou19 boubou19 closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants