Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Essentia Condenser Nuke #2 #779

Closed
wants to merge 1 commit into from
Closed

Essentia Condenser Nuke #2 #779

wants to merge 1 commit into from

Conversation

Alastors
Copy link
Contributor

@Alastors Alastors commented Dec 13, 2023

As promised, the second something that could feasibly replace the condenser gets introduced, I'd nuke the condenser, here that is.

I'm going to leave the condenser itself in-tact as a block in-case someone actually wants to fix it in the future (this just removes the recipe replacements from coremod, base recipes were handled as well)

Sister PR to:
GTNewHorizons/MagicBees#34
and
GTNewHorizons/Gadomancy#26

Fixes:
GTNewHorizons/GT-New-Horizons-Modpack#10522

As promised, the second something that could feasibly replace the condenser gets introduced, I'd nuke the condenser, here that is.

I'm going to leave the condenser itself in-tact as a block in-case someone actually wants to fix it in the future (this just removes the recipe replacements from coremod, base recipes were handled as well)

Sister PR to:
GTNewHorizons/MagicBees#34
and
GTNewHorizons/Gadomancy#26
@Dream-Master Dream-Master added the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Dec 13, 2023
@Dream-Master Dream-Master requested a review from a team December 13, 2023 06:50
@Dream-Master
Copy link
Member

@Alastors since Element of darkness have no use we can use it for the new crafting recipe as well.

@Alastors
Copy link
Contributor Author

@Alastors since Element of darkness have no use we can use it for the new crafting recipe as well.

I genuinely don’t think we should do that, IMO the essentia bee is already going to be a little weak, likewise it wouldn’t really make sense since it’s not really a 1:1 replacement

@Alastors Alastors closed this Dec 13, 2023
@Alastors Alastors reopened this Dec 13, 2023
@Dream-Master Dream-Master marked this pull request as draft December 14, 2023 10:34
@Dream-Master
Copy link
Member

@Alastors i set it draft

@Dream-Master Dream-Master removed the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Dec 18, 2023
@Dream-Master
Copy link
Member

Not needed anymore

@Dream-Master Dream-Master deleted the condenser-nuke branch December 22, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants