Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various recipe fixes and tweaks #788

Merged
merged 17 commits into from
Jan 12, 2024

Conversation

AbdielKavash
Copy link
Member

@AbdielKavash AbdielKavash commented Jan 5, 2024

I went through github issues and my own notes and collected a set of various minor recipe issues and requests, and implemented all I could find. None of these should have a significant balance impact.

I did my best to make sure that none of the added/changed recipes have any recipe conflict in the full pack.

@Dream-Master Dream-Master requested a review from a team January 5, 2024 13:35
@chochem
Copy link
Member

chochem commented Jan 6, 2024

why are many recipes added in scripts when its mostly normal gt recipes?

GT_Values.RA.stdBuilder()
.itemInputs(
GT_OreDictUnificator.get(OrePrefixes.plate, Materials.Iron, 4),
ItemList.Circuit_Microprocessor.get(1L),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this on purpose? These itemlist circuits should only be used if you want to forbid unification (multiple occurences, not just here)

@AbdielKavash
Copy link
Member Author

AbdielKavash commented Jan 6, 2024

I tried following the adjacent code for similar recipes as closely as I could, both for placement and for methods used. Is there some documentation that I could read for the "proper" way of doing this? So far I'm trying to learn by following the code that is already there.

@chochem
Copy link
Member

chochem commented Jan 6, 2024

not really. Scripts folder are mostly autoconverted things though, so often not ideal, unless they got a good cleanup.
If you look at the itemlist you use, you can see it specificly has the no-unification tag. So if you want to allow all circuits of the tier (which is almost always the case) you cant use that but should use the gt oredictunificator for example.
When it comes to where recipes go our current idea is to put gt machine recipes in the folder for that machine. Required mods are then just checked for a small section of recipes or even individually directly now with the new option miozune added to RA2.

@AbdielKavash
Copy link
Member Author

What would you recommend then? Should I keep the new recipes together with the old ones, for consistency? Or move them to the respective machine-specific files? Or even move everything (both newly added recipes and the old ones) to where they should be now?

@chochem
Copy link
Member

chochem commented Jan 7, 2024

I would move just move them.
Moving them all would also be nice but is a lot of work and might also include some more cleanup. I might get back to that at some point.

Copy link
Member

@chochem chochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well the moving is one thing. And since the file is not cleaned up anyway, its not critical.

But you need to fix the circuits.

@AbdielKavash
Copy link
Member Author

AbdielKavash commented Jan 12, 2024

I have cleaned up the circuits and other OreDict nonsense in Project Red and Logistics Pipes. I also caught two minor errors, the time of one recipe was obviously wrong; and two recipes in Logistics Pipes were missing a programmed circuit. I have manually verified the changes side-by-side to make sure nothing went missing.

I agree that as a whole the coremod recipes need a huge amount of cleanup and reorganization. But that should be done separately in a different PR.

Copy link
Member

@chochem chochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah you cleaned up the entire 2 files now and not just your recipes. thats awesome!

I dont see any mistakes or missing stuff right now but of course its a lot.

@boubou19 boubou19 merged commit 9e520b5 into GTNewHorizons:master Jan 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment