Fix UMV and UXV circuit oreDicts #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2024
|
The build fails because of a badly-implemented oreDict ItemStack getter in gt5u which causes a NPE error when the oreDict doesn't have anything in it, which happens to be the case after this PR as it moves the circuit oreDicts. Fixed by GTNewHorizons/GT5-Unofficial#2739 |
boubou19
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The circuits have been oreDicted to the wrong Material enum since forever. With some new UMV and UXV circuits (namely the Any circuits), this actually starts to matter.
Also changes a few recipes which were using non-oreDicted circuits in their recipes.
Dependancy of:
GTNewHorizons/GTNH-Intergalactic#64
GTNewHorizons/GT5-Unofficial#2739