Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stargateController recipe #982

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

wohaopa
Copy link
Contributor

@wohaopa wohaopa commented Sep 8, 2024

I want to add a recipe for this block, but I'm not sure if it's appropriate.
GTNewHorizons/SGCraft#19

@Dream-Master Dream-Master requested review from serenibyss and a team September 8, 2024 09:12
Copy link
Contributor

@NotAPenguin0 NotAPenguin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While appreciated, I think this should be a part of #980 instead of going in a separate PR.

@Dream-Master Dream-Master requested a review from a team September 8, 2024 09:27
@NotAPenguin0 NotAPenguin0 dismissed their stale review September 8, 2024 09:28

not against master

@wohaopa
Copy link
Contributor Author

wohaopa commented Sep 8, 2024

While appreciated, I think this should be a part of #980 instead of going in a separate PR.

I agree. What should I do?

@Dream-Master
Copy link
Member

@wohaopa all fine you already add it to this branch.

@NotAPenguin0
Copy link
Contributor

This is fine, I didn't see the PR was going into the 2.7-stargate branch instead of master

Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I love the idea. We will probably tweak the recipe some, but I'll merge it into the Stargate PR in the meantime

@serenibyss serenibyss merged commit a1052b8 into GTNewHorizons:2.7-stargate Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants