-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new chests (from @unicornbloods) #16
Conversation
…ilar to netherite icon
Netherite chests
Add Dark Steel for GTNH Netherite equivalent. Add config option to use steel chest instead of silver with the default being true.
Add darksteel, netherite and silver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ist that intended to use ingotNetherit
for dark steel chest? Not sure if they have the same oredict entry.
Also, would it be an idea to also add a config to control netherit/dark steel variants instead of the dreamcraft mod, same as steel/silver variants? I am going to test this PR later this day on a modpack outside gtnh (on my test server) with many gtnh mods and someothers. But maybe someone's else still want to try this on an existing gtnh modpack wold. |
Feel free to make the changes, just remember that this mod is on the passive list |
Alright, I tested this with some scenarious by turning the config What I changed in the source code:
I've seen that the mappings of turning off |
Sure. That's why I asked before. 😊 |
I request another dev to review since I added own changes and I am not longer in the position to review this. However, from my side it's a OK. See my comment above. |
works and tested in GTNH full pack |
Check please silver chest. |
@Pilad Can you confirm that with the latest nightly? |
|
Did you spawn that in manually? |
Place iron chest . Click upgrade iron to silver. Try open gui. |
I noticed the issue and created a PR for it. Turns out whoever added the iron to silver upgrade forgot to add it to a list. |
Thanks for fixing the problem. |
See PR: #14
Confirmed working in pack.
Need someone to test in an existing world that already has iron chests