-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tier handling & recipe generation #19
Conversation
…ons/ironchest into fix/re-organize-tiers
As of now I am ready with this and my local tests seems to be fine. But I still want to give it a test on my private test server to ensure it works fine on an existing world. There are just a few upgrades missing that needs to be added. The recipes for upgrading a chest block are available. If someone want to test this with a GTNH world, feel free. :) |
It's finished now and ready for review. Later this day when I finsihed work I'm going to test this on my test server to go 100%ly sure everything works fine even an existing world. From my dev-tests everything seems fine under the following conditions:
|
…ons/ironchest into fix/re-organize-tiers
Netherite is only supposed supposed to be upgradable from Obsidian. Can you add a config for each thing. |
Sure. |
Thank you! ❤️ |
Added another commit restoring the previous behavior regarding explosion safenes. Netherite can not be upgraded from anything else then obsidian. If you still want to see configs for each upgrade and depending recipe, then I need some time the next days to find a good solution to keep that dynamic without hardcoding it (I don't like hardcoding things). |
It's no rush |
I now added a new config containing a string list with an iron-to-gold upgrade example: # Disallowed upgrades. All upgrades listed here will not be registred and no recipes will be generated for it.
# Example: IRON:GOLD [default: ]
S:blocklistUpgrades <
IRON:GOLD
> If a upgrade is listed in this blacklist then there will no recipes generated for upgrading chest and the upgrade-items will not even be registred to the GameRegistry. I hope that fits your needs. :) I've chosen this way instead of the upgrade names directly to be able to handle upgrades also for chest recipes without the need to check the specific upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the one problem with dark steel upgrade items. Tested it inside and outside of GTNH pack and works as expected other than that.
Thank you a lot for your test and review @Cleptomania! I addressed your changes, this is again ready for review. |
With this PR I want to improve the handling of different tiers and make it more dynamically. It will then be easier to add new tiers or add and enable multiple versions of a block within one tier.
At the moment this PR has the state of before but adds a few more recipes due dynamic recipe generation wich does NOT affect the usage in GTNH as within GTNH the recipes get not generated at all.
I am not sure about compat between IronChestMinecarts and IronTanks, I only tested Et Futurum Requiem and this still works fine.
Todo: