Simplify AddOpens by including them in the manifest file #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After further testing, I have been unable to find a way open the security manager or set the class loader outside of the command line. |
spacebuilder2020
changed the title
Failed making field 'java.lang.ref.Reference#referent' accessible Failed making field 'java.util.concurrent.locks.ReentrantLock#sync' accessible
spacebuilder2020
commented
May 6, 2024
| @@ -24,6 +24,8 @@ val addOpens = listOf( | |||
| "java.base/java.nio=ALL-UNNAMED", | |||
| "java.base/java.io=ALL-UNNAMED", | |||
| "java.base/java.lang=ALL-UNNAMED", | |||
| "java.base/java.lang.ref=ALL-UNNAMED", | |||
There was a problem hiding this comment.
Ran into this issue on my server when saving data files for Forge Essentials using the bundled gson library
Since Forge Essentials does not bundle gson, I think this is a fix that belongs in lwjgl3ify since it might effect other mods as well.
eigenraven
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies AddOpens section by including it as a manifest attribute. I have tested this on my server and the server still boots after removing the --add-opens section from the java9 args file.
As for the other properties, something like
if (!System.getProperties() .contains("file.encoding")) { System.getProperties() .put("file.encoding", "UTF-8"); }in the main class would work but I am not sure things likejava.system.class.loaderorjava.security.managercould be injected that way.