Adjustments needed to get Angelica (Iris/Oculus backport) working #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchej123
force-pushed
the
angelica-work
branch
from
d0a1725 to
9c14819
Compare
mitchej123
commented
Nov 23, 2023
| @@ -154,6 +154,13 @@ public static void glGetActiveUniform(int program, int index, java.nio.IntBuffer | |||
| org.lwjgl.opengl.GL20.glGetActiveUniform(program, index, length, size, type, name); | |||
| } | |||
|
|
|||
| public static String glGetActiveUniform(int program, int index, int maxLength, java.nio.IntBuffer sizeType) { | |||
| java.nio.IntBuffer type = org.lwjgl.BufferUtils.createIntBuffer(1); | |||
There was a problem hiding this comment.
Worth reusing a (static) buffer for this? 🤔
There was a problem hiding this comment.
possibly, a ThreadLocal would make sense
eigenraven
approved these changes
Nov 23, 2023
eigenraven
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.