Match concrete size array #1074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
reviewed
Apr 3, 2023
| @@ -1629,6 +1632,21 @@ possibleAllocs n mem = | |||
| Just (AllocInfo atp sz mut alignment loc) -> | |||
| [SomeAlloc atp n sz mut alignment loc] | |||
|
|
|||
|
|
|||
| newtype MemoIO m a = MemoIO (IORef (Either (m a) a)) | |||
There was a problem hiding this comment.
Please leave some comments stating with the conventions are for MemoIO. If I understand correctly, Left indicates a suspended computation and Right indicates an evaluated result, but it would be helpful to state this explicitly.
| @@ -527,15 +528,16 @@ multiUnion :: (Ord k, Semigroup a) => Map k a -> Map k a -> Map k a | |||
| multiUnion = Map.unionWith (<>) | |||
|
|
|||
| writeSourceSize :: | |||
There was a problem hiding this comment.
This will only ever return pure Nothing if the WriteSource corresponds to a byte array of unbounded size, correct? It would be worth adding some Haddocks stating as much.
(This isn't your fault, as this function existed in Haddock-less form before this patch, but it would be worth addressing this now that we export this function in the public API.)
andreistefanescu
force-pushed
the
match-concrete-size-array
branch
4 times, most recently
from
adb26d8 to
4943522
Compare
andreistefanescu
force-pushed
the
match-concrete-size-array
branch
from
8285ac0 to
98428da
Compare
RyanGlScott
force-pushed
the
match-concrete-size-array
branch
from
98428da to
470cb28
Compare
RyanGlScott
force-pushed
the
match-concrete-size-array
branch
from
470cb28 to
5c2c29c
Compare
|
Superseded by #1178. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.