Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require what4-1.6.1, llvm-pretty-0.12.1 in .cabal files #1247

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Require what4-1.6.1, llvm-pretty-0.12.1 in .cabal files #1247

merged 4 commits into from
Sep 3, 2024

Conversation

RyanGlScott
Copy link
Contributor

This ensures that the .cabal files for crucible and crucible-llvm declare the appropriate lower version bounds on llvm-pretty and what4. This also bumps the submodules to the required minimum versions of these libraries.

Fixes #1246.

@RyanGlScott
crucible-llvm: Explicitly require llvm-pretty-0.12.1 or greater
4661e4e 
As of #1226, `crucible-llvm` requires `llvm-pretty-0.12.1` or later to build,
but this was not reflected in the `.cabal` file's version bounds. Fix this, and
bump the `llvm-pretty` submodule to pin against version 0.12.1.

Related to #1246.
@RyanGlScott
crucible: Explicitly require what4-1.6.1 or greater
9399334 
As of #1211, `crucible` requires `what4-1.6.1` or later to build, but this was
not reflected in the `.cabal` file's version bounds. Fix this, and also bump
the `what4` submodule to version 1.6.1.

Fixes #1246.
@RyanGlScott
Bump llvm-pretty submodule to development version 0.12.1.0.99
591614e
@RyanGlScott
Bump what4 submodule to development version 1.6.1.0.99
5aa3038
@RyanGlScott RyanGlScott merged commit 8021814 into master Sep 3, 2024
32 checks passed
@RyanGlScott RyanGlScott deleted the T1246-what4-1.6.1 branch September 3, 2024 16:52
@RyanGlScott
Copy link
Contributor Author

I have:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kquick kquick kquick approved these changes

@langston-barrett langston-barrett langston-barrett approved these changes

@mccleeary-galois mccleeary-galois Awaiting requested review from mccleeary-galois

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crucible-0.7.1 Hackage release does not compile
3 participants
@RyanGlScott @kquick @langston-barrett