crux-llvm: Uniformly use LLVM 14 in Dockerfile
#1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the Dockerfile was inconsistent about whether it referred to LLVM 12 or 14. This patch changes the Dockerfile to uniformly refer to the current LLVM version using an `LLVM_VER` `ARG` (defined to be `14`), which is passes to both stages of the build. Fixes #1257.
|
CI job which shows the Docker job now succeeding: https://github.com/GaloisInc/crucible/actions/runs/11014053625/job/30583802466 |
langston-barrett
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Dockerfile was inconsistent about whether it referred to LLVM 12 or 14. This patch changes the Dockerfile to uniformly refer to the current LLVM version using an
LLVM_VERARG(defined to be14), which is passes to both stages of the build.Fixes #1257.