Parse atomic operations introduced in LLVM 9+ #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kquick
approved these changes
Jul 25, 2024
RyanGlScott
force-pushed
the
new-atomic-operations
branch
from
84821be to
7058d27
Compare
This adapts `llvm-pretty-bc-parser` to new atomic operations introduced in LLVM 9 and later: * This bumps the `llvm-pretty` submodule to incorporate the changes from GaloisInc/llvm-pretty#138 and GaloisInc/llvm-pretty#140. * This updates the parsing code in `Data.LLVM.BitCode.IR.Function` to account for atomic `fadd`, `fsub`, `fmax`, `fmin`, `uinc_wrap`, and `udec_wrap` operations. * This ensures that all atomic operations have a corresponding `disasm-test` test case.
RyanGlScott
force-pushed
the
new-atomic-operations
branch
from
7058d27 to
4f85bba
Compare
RyanGlScott
added a commit
to GaloisInc/crucible
that referenced
this pull request
Jul 25, 2024
This adapts `crucible-llvm` to new atomic operations introduced in LLVM 9 and later: * This bumps the `llvm-pretty` submodule to incorporate the changes from GaloisInc/llvm-pretty#138 and GaloisInc/llvm-pretty#140. * This bumps the `llvm-pretty-bc-parser` submodule to incorporate changes from GaloisInc/llvm-pretty-bc-parser#274. * This updates `crucible-llvm`'s semantics for the `atomicrmw` instruction to account for atomic `fadd`, `fsub`, `fmax`, `fmin`, `uinc_wrap`, and `udec_wrap` operations. * This ensures that all atomic operations have a corresponding `crux-llvm` test case.
RyanGlScott
added a commit
to GaloisInc/crucible
that referenced
this pull request
Jul 26, 2024
This adapts `crucible-llvm` to new atomic operations introduced in LLVM 9 and later: * This bumps the `llvm-pretty` submodule to incorporate the changes from GaloisInc/llvm-pretty#138 and GaloisInc/llvm-pretty#140. * This bumps the `llvm-pretty-bc-parser` submodule to incorporate changes from GaloisInc/llvm-pretty-bc-parser#274. * This updates `crucible-llvm`'s semantics for the `atomicrmw` instruction to account for atomic `fadd`, `fsub`, `fmax`, `fmin`, `uinc_wrap`, and `udec_wrap` operations. * This ensures that all atomic operations have a corresponding `crux-llvm` test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts
llvm-pretty-bc-parserto new atomic operations introduced in LLVM 9 and later:llvm-prettysubmodule to incorporate the changes from Support moreAtomicRWOps llvm-pretty#138 and Fix pretty-printing foruinc_wrapandudec_wrapllvm-pretty#140.Data.LLVM.BitCode.IR.Functionto account for atomicfadd,fsub,fmax,fmin,uinc_wrap, andudec_wrapoperations.disasm-testtest case.