fix printing of Infinites and NaNs #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes GaloisInc#135 In a nutshell, the old pretty-printing would output "Infinite" for infinite floating point values, which is not valid LLVM IR. Instead, we must output the hexadecimal representation of the floating point value.
|
Thanks! Would you be willing to add a couple of unit tests for this change? Relatedly, |
|
There is no round-trip testing here, but adding some round-trip tests to |
|
To be clear, I wasn't imagining a full round-trip test, but rather something like |
|
How about these tests? |
Ptival
force-pushed
the
vr/fix-printing-infinite
branch
from
fa5a45c to
25509ff
Compare
RyanGlScott
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #135
In a nutshell, the old pretty-printing would output "Infinite" for infinite floating point values, which is not valid LLVM IR. Instead, we must output the hexadecimal representation of the floating point value.