More parameterization for functions not needing a specialized type parameter. #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
approved these changes
Dec 9, 2024
src/Text/LLVM/AST.hs
Outdated
Comment on lines
483
to
487
| isAlias :: Type' ident -> Bool | ||
| isAlias Alias{} = True | ||
| isAlias _ = False | ||
|
|
||
| isPrimTypeOf :: (PrimType -> Bool) -> Type -> Bool | ||
| isPrimTypeOf :: (PrimType -> Bool) -> Type' lab -> Bool |
There was a problem hiding this comment.
The code here is inconsistent about calling Type's type parameter ident or lab (and similarly with the code below). I think we should pick one convention and stick to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weakens type declarations to be more permissive where the stricter type isn't needed. This should not affect any existing uses, but permits a broader utilization of these functions where desireable.