Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing target triples #96

Merged
merged 27 commits into from
Sep 27, 2022
Merged

Parsing target triples #96

merged 27 commits into from
Sep 27, 2022

Conversation

langston-barrett
Copy link
Collaborator

Fixes #21.

@langston-barrett
ASTs of target triples
78acfab
@langston-barrett
Introduce Triple.Print
e290161
@langston-barrett
Triple.Print: osName
d68dfee
@langston-barrett
Triple.Print: envName
918a812
@langston-barrett
Triple.Print: vendorName, objFmtName
8d05747
@langston-barrett
Introduce Triple.Parse
f0994e4
@langston-barrett
Skeleton of test suite
15579af 
Also, use common stanza to avoid repetition and make corresponding changes to
Cabal file.
@langston-barrett
Skeleton of triple tests
dece9b9
@langston-barrett
Test print-then-parse roundtrip for Vendor
0a3e12e
@langston-barrett
Fix return type of parseVendor
f6a9426 
Vendor has an "unknown" constructor, which should be used instead of Nothing.
@langston-barrett
Add a Haddock for parseVendor
65c628e
@langston-barrett
Triple.Parse: Add parseOS
2ec7334
@langston-barrett
Triple.Parse: Refactor, use a newtype for LookupTable
80ab2bc
@langston-barrett
Triple.Parse: Add parseEnv
0f9a66f
@langston-barrett
Triple.Parse: Add parseObjFmt
4c89c59
@langston-barrett
Triple.Parse: More Haddocks for internal helpers
a7fd08b
@langston-barrett
Triple.Parse: Introduce lookupByWithDefault
5826948
@langston-barrett
Triple.Parse: Introduce variants
ea6f361
@langston-barrett
Triple.Parse: Arch
6f74820
@langston-barrett
Triple.Parse: Towards parseSubArch
cc934e1
@langston-barrett
Fix Monoid instance for Module to actually be pointwise
c973d98
@langston-barrett
Triple.Parse.ARM: parseArch
e79b7b9
@langston-barrett
Triple.Parse: Finish parseSubArch
8b0647b
@langston-barrett
Triple.Parse: parseTriple
a74f017
@langston-barrett langston-barrett self-assigned this Sep 23, 2022
@RyanGlScott
Copy link
Collaborator

Is it expected that this fails to parse the ELF object format?

λ> parseTriple "i386-unknown-linux-elf"
TargetTriple {ttArch = X86, ttSubArch = NoSubArch, ttVendor = UnknownVendor, ttOS = Linux, ttEnv = UnknownEnvironment, ttObjFmt = UnknownObjectFormat}

@langston-barrett
Copy link
Collaborator Author

Is it expected that this fails to parse the ELF object format?

Indeed not. The problem is that I was treating object formats as a fifth field of a target triple, when they apparently overlap with the "environment" as the fourth field. Thanks for pointing this out, I've added a test with that triple!

RyanGlScott
RyanGlScott approved these changes Sep 23, 2022
View reviewed changes
src/Text/LLVM/Triple/Parse.hs Outdated Show resolved Hide resolved
src/Text/LLVM/Triple/Parse/ARM.hs Outdated Show resolved Hide resolved
src/Text/LLVM/Triple/AST.hs Show resolved Hide resolved
elliottt
elliottt approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thank you for adding this! When you do create the issues, could you link them back in the comment threads?

This was referenced Sep 27, 2022
Open
Open
@langston-barrett
Copy link
Collaborator Author

When you do create the issues, could you link them back in the comment threads?

For sure, done!

@langston-barrett langston-barrett merged commit 31612ff into GaloisInc:master Sep 27, 2022
@langston-barrett langston-barrett deleted the lb/triple branch September 27, 2022 15:06
@langston-barrett langston-barrett mentioned this pull request Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

@elliottt elliottt elliottt approved these changes

Assignees

@langston-barrett langston-barrett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse/print target triples
3 participants
@langston-barrett @RyanGlScott @elliottt