Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require lens >= 5 #150

Closed

Conversation

langston-barrett
Copy link
Contributor

@langston-barrett langston-barrett commented Feb 8, 2023

Fixes #152.

@RyanGlScott
Copy link
Contributor

In principle, I am supportive of this idea. My only concern about this is that we might make it more difficult to build with other libraries that still require lens<5. I don't have a specific example to cite, but I seem to recall that you ran into a situation like this recently?

@langston-barrett
Copy link
Contributor Author

I don't have a specific example to cite, but I seem to recall that you ran into a situation like this recently?

Yes, unfortunately that's in a closed-source project so I can't share specifics.

My only concern about this is that we might make it more difficult to build with other libraries that still require lens<5.

Doesn't your example on #149 demonstrate that it's already impossible to build p-u with libraries that depend on lens<5? Or am I misunderstanding that?

FWIW, lens 5 came out a full two years ago.

@RyanGlScott
Copy link
Contributor

Doesn't your example on #149 demonstrate that it's already impossible to build p-u with libraries that depend on lens<5?

Currently, that is the case. The question is whether we would want to support doing so into the future. Given how old lens-5 is, however, perhaps the solution is to just force the rest of the ecosystem to catch up.

@langston-barrett
Copy link
Contributor Author

After merging #151 and so fixing #152, there is no immediate need to change this lower bound.

@langston-barrett langston-barrett deleted the lb/lens-5-min branch February 16, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect lower bound for lens
2 participants