Re-organize with internal libraries to hide safe/unsafe internals. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hides the Safe/Unsafe implementations of Context which prevents a client from improperly using the wrong one. This also allows client code and tests to be written in a fully generic manner. The internal movement/splitting of files is somewhat unfortunate, but Cabal will look for a local file to supply an import statement before checking libraries, so the files had to be segregated physically as well as by internal library build.
|
@kquick What's the status of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hides the Safe/Unsafe implementations of Context which prevents a
client from improperly using the wrong one.
This also allows client code and tests to be written in a fully
generic manner.
The internal movement/splitting of files is somewhat unfortunate, but
Cabal will look for a local file to supply an import statement before
checking libraries, so the files had to be segregated physically as
well as by internal library build.