Prepare to deprecate llvm_struct #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change references to either llvm_alias (which has the same type and does the same thing) or llvm_struct_type (which is sometimes what people referring to llvm_struct are actually trying to do). Alas, the manual was wrong and cited llvm_struct when it wanted llvm_struct_type...
sauclovian-g
requested review from
RyanGlScott,
ChrisEPhifer and
mccleeary-galois
ChrisEPhifer
approved these changes
Jan 22, 2025
|
The failures here are #2166 again and not anything here being broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleanup part of #2159.