fix: allow test numbers

GaloyMoney · Feb 5, 2025 · bf7871e · bf7871e
1 parent 8439e0a
commit bf7871e
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/core/api/src/app/authentication/request-code.ts b/core/api/src/app/authentication/request-code.ts
@@ -52,9 +52,6 @@ export const requestPhoneCodeWithCaptcha = async ({
     if (limitOk instanceof Error) return limitOk
   }
 
-  const checkedChannel = checkedToChannel(phone, channel)
-  if (checkedChannel instanceof Error) return checkedChannel
-
   if (UNSECURE_DEFAULT_LOGIN_CODE) {
     return true
   }
@@ -71,6 +68,9 @@ export const requestPhoneCodeWithCaptcha = async ({
   const user = await UsersRepository().findByPhone(phone)
   const phoneExists = !(user instanceof Error)
 
+  const checkedChannel = checkedToChannel(phone, channel)
+  if (checkedChannel instanceof Error) return checkedChannel
+
   return TwilioClient().initiateVerify({
     to: phone,
     channel: checkedChannel,
@@ -103,9 +103,6 @@ export const requestPhoneCodeForAuthedUser = async ({
     return new PhoneAlreadyExistsError()
   }
 
-  const checkedChannel = checkedToChannel(phone, channel)
-  if (checkedChannel instanceof Error) return checkedChannel
-
   if (UNSECURE_DEFAULT_LOGIN_CODE) {
     return true
   }
@@ -119,6 +116,9 @@ export const requestPhoneCodeForAuthedUser = async ({
     return true
   }
 
+  const checkedChannel = checkedToChannel(phone, channel)
+  if (checkedChannel instanceof Error) return checkedChannel
+
   return TwilioClient().initiateVerify({
     to: phone,
     channel: checkedChannel,
@@ -154,9 +154,6 @@ export const requestPhoneCodeWithAppcheckJti = async ({
     if (limitOk instanceof Error) return limitOk
   }
 
-  const checkedChannel = checkedToChannel(phone, channel)
-  if (checkedChannel instanceof Error) return checkedChannel
-
   if (UNSECURE_DEFAULT_LOGIN_CODE) {
     return true
   }
@@ -173,6 +170,9 @@ export const requestPhoneCodeWithAppcheckJti = async ({
   const user = await UsersRepository().findByPhone(phone)
   const phoneExists = !(user instanceof Error)
 
+  const checkedChannel = checkedToChannel(phone, channel)
+  if (checkedChannel instanceof Error) return checkedChannel
+
   return TwilioClient().initiateVerify({
     to: phone,
     channel: checkedChannel,