Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/maroon 491 ci status check #492

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

mfbrantner
Copy link
Collaborator

The test job now creates status checks for playmode and editmode test results.
Also, game-ci/unity-test-runner has been bumped to v4.3.1.

The results can be found here:
Screenshot 2024-07-11 at 20-26-54 bump unity-test-runner action to version 4 3 1 · GameLabGraz_Maroon@2bc48ff

They look as follows:

✅ -> Pass
⚠️ -> Skipped
❌ -> Failed

Screenshot 2024-07-11 at 20-19-46 bump unity-test-runner action to version 4 3 1 · GameLabGraz_Maroon@2bc48ff

Closes #491.

@mfbrantner mfbrantner requested a review from michaelholly July 12, 2024 09:54
Copy link
Collaborator

@FlorianGlawogger FlorianGlawogger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, this will be incredibly useful! Makes test results so much easier to read! Thanks a lot! 😄

@FlorianGlawogger FlorianGlawogger merged commit 788cd0f into develop Jul 17, 2024
8 checks passed
@FlorianGlawogger FlorianGlawogger deleted the enhancement/Maroon-491_ci_status_check branch July 17, 2024 08:10
@FlorianGlawogger
Copy link
Collaborator

Hi @mfbrantner
When I check the automatic daily build from today (3 hours ago) https://github.com/GameLabGraz/Maroon/actions/runs/9986298233, I don't see the test results displayed there;
but the build from yesterday https://github.com/GameLabGraz/Maroon/actions/runs/9970556437 has the test results from yesterday, and the test results from 3 hours ago.
grafik

Is this the same for you as well? If so, do you know anything regarding that/how to fix that?

@mfbrantner
Copy link
Collaborator Author

Unfortunately it appears that this is the intended behavior of this feature.
Status checks are created for the first workflow run for that specific commit.
Subsequent workflow runs of the same commit will add the status check to that first workflow run.

The same would also happen, when a workflow is re-run manually.
I did not find a proper way to "fix" this behavior, as it seems to be intentional.

I'll try to reach out to the devs of the unity-test-runner action to see if they have more info on that!

@mfbrantner
Copy link
Collaborator Author

Seems like this was already brought up in game-ci/unity-test-runner#222.

And it also seems like GitHub has little interest in fixing it :/
https://github.com/orgs/community/discussions/24616

@FlorianGlawogger
Copy link
Collaborator

@mfbrantner Thanks for your reply and your efforts! Oh okay, if it's a Unity-test-runner/Github issue, then we can't do anything about it right now anyway. Thanks again for looking into this though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI test results are cumbersome to read
2 participants