Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quick toggle emulation #20

Merged
merged 13 commits into from
Jun 26, 2024

Conversation

jadeiseepy
Copy link
Contributor

@jadeiseepy jadeiseepy commented Jun 21, 2024

Like the quick select hotkey, but it removes the amiibo. This should make playing games like Mario Party 10 easier, also it's just generally more convenient

Haven't tested yet, will test in a sec

@jadeiseepy jadeiseepy marked this pull request as draft June 21, 2024 23:16
@jadeiseepy
Copy link
Contributor Author

Okay, notifications don't seem to work. Don't know why though...

@jadeiseepy
Copy link
Contributor Author

Ah, okay, looks like there was a bug in the anti-hold down system, I'll try again :3

@jadeiseepy
Copy link
Contributor Author

Nope, that doesn't seem to be it.

plugin/source/quick_select.cpp Outdated Show resolved Hide resolved
plugin/source/quick_select.cpp Outdated Show resolved Hide resolved
Co-authored-by: GaryOderNichts <[email protected]>
@jadeiseepy jadeiseepy marked this pull request as ready for review June 22, 2024 14:03
Copy link
Owner

@GaryOderNichts GaryOderNichts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the menu option should be called Quick Remove Combo if it toggles the emulation state. Maybe something like Toggle Emulation Combo or similar works better.

@jadeiseepy
Copy link
Contributor Author

Ah, yeah, good point.

@GaryOderNichts
Copy link
Owner

Can you rename the associated variables and names too?

@jadeiseepy
Copy link
Contributor Author

Yep, should be all good now

@jadeiseepy
Copy link
Contributor Author

Should be fixed now

Co-authored-by: GaryOderNichts <[email protected]>
@jadeiseepy
Copy link
Contributor Author

Gotcha. should be ready to go now

@GaryOderNichts
Copy link
Owner

Thanks, LGTM now. I'll give this a test in a bit.

@GaryOderNichts GaryOderNichts changed the title WIP: Add quick toggle emulation Add quick toggle emulation Jun 26, 2024
@GaryOderNichts GaryOderNichts merged commit 87eddda into GaryOderNichts:main Jun 26, 2024
1 check passed
@GaryOderNichts
Copy link
Owner

Seems to work fine. Thanks for the feature!

@jadeiseepy
Copy link
Contributor Author

No problem!

@jadeiseepy jadeiseepy deleted the quicktoggle branch June 26, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants