-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge changes into release branch #522
Conversation
feat: replace url states with provider
… docker tag to v9
* fix: free text values sync with global states * feat: provide user feedback for incorrect free text values
…try.access.redhat.com-ubi9-nodejs-20-minimal-9.x chore(deps): update registry.access.redhat.com/ubi9/nodejs-20-minimal docker tag to v9
…source-sonarqube-scan-action-4.x chore(deps): update sonarsource/sonarqube-scan-action action to v4
…ortal-frontend-and-dds-display-themes-and-publisher-from-backend feat: ART-9692/add themes and publishers
…-minimal docker tag to v9"
…ovate/registry.access.redhat.com-ubi9-nodejs-20-minimal-9.x Revert "chore(deps): update registry.access.redhat.com/ubi9/nodejs-20-minimal docker tag to v9"
…ortal-frontend-and-dds-display-themes-and-publisher-from-backend feat: ART-9692/change themes in homepage
…reuse-action-5.x chore(deps): update fsfe/reuse-action action to v5
…-nextjs-monorepo fix(deps): update dependency next to v14.2.18
…-devdependencies chore(deps): update dependency eslint-config-next to v14.2.18
This is needed because latest UBI image has a bug and trivy is not capable to fetch vulnerability lists. aquasecurity/trivy-db#435
* fix: ART-9692/displaying themes on homepage correctly * add test * fix prettier * fix compliance
…-devdependencies chore(deps): update dependency tailwindcss to v3.4.15
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6. - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…_and_yarn/cross-spawn-7.0.6 chore(deps): bump cross-spawn from 7.0.3 to 7.0.6
…portal-frontend-not-showing-filter-labels-in-applied-filters fix: ART-10765/not showing filter labels in applied filters
…fns-4.x fix(deps): update dependency date-fns to v4
…elemetry-js-monorepo fix(deps): update opentelemetry-js monorepo to ^0.55.0 (minor)
This reverts commit 00a1570.
…-nextjs-monorepo fix(deps): update dependency next to v15
…ovate/major-nextjs-monorepo Revert "fix(deps): update dependency next to v15"
…ecurity-trivy-action-0.x chore(deps): update aquasecurity/trivy-action action to v0.29.0
… docker tag to v9
…try.access.redhat.com-ubi9-nodejs-20-minimal-9.x chore(deps): update registry.access.redhat.com/ubi9/nodejs-20-minimal docker tag to v9
… docker tag to v9.5-1732617235
…try.access.redhat.com-ubi9-nodejs-20-minimal-9.5.x chore(deps): update registry.access.redhat.com/ubi9/nodejs-20-minimal docker tag to v9.5-1732617235
Reviewer's Guide by SourceryThis pull request implements a new filter management system using React Context and introduces several UI components for handling different types of filters (dropdown, free text, and entries). The changes include refactoring the dataset search functionality to use the new filter system and updating related components to work with the new implementation. Sequence diagram for Filter Application ProcesssequenceDiagram
actor User
participant FilterProvider
participant FilterList
participant ActiveFilters
User->>FilterList: Select filter
FilterList->>FilterProvider: addActiveFilter(filter)
FilterProvider->>ActiveFilters: Update active filters
ActiveFilters->>User: Display active filters
User->>ActiveFilters: Remove filter
ActiveFilters->>FilterProvider: removeActiveFilter(key, source)
FilterProvider->>ActiveFilters: Update active filters
ActiveFilters->>User: Display updated filters
Class diagram for Filter Management SystemclassDiagram
class FilterProvider {
+Filter[] filters
+ActiveFilter[] activeFilters
+boolean isLoading
+error
+addActiveFilter(ActiveFilter)
+removeActiveFilter(string, string)
+clearActiveFilters()
}
class ActiveFilter {
+string source
+string type
+string key
+string label
+Value[] values
+ActiveFilterEntry[] entries
}
class Value {
+string value
+string label
+Operator operator
}
class ActiveFilterEntry {
+string key
+string label
+string value
}
class Filter {
+string source
+string type
+string key
+string label
+Value[] values
+Operator[] operators
+FilterEntry[] entries
}
class FilterEntry {
+string key
+string label
}
FilterProvider --> ActiveFilter
ActiveFilter --> Value
ActiveFilter --> ActiveFilterEntry
Filter --> Value
Filter --> FilterEntry
Class diagram for Dataset Search TypesclassDiagram
class DatasetSearchOptions {
+string query
+Facet[] facets
+string sort
+number rows
+number start
+QueryOperator operator
}
class Facet {
+string source
+string type
+string key
+string value
+Operator operator
+FacetEntry[] entries
}
class FacetEntry {
+string key
+string value
}
class ValueLabel {
+string label
+string value
+number count
}
DatasetSearchOptions --> Facet
Facet --> FacetEntry
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jadzlnds - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider syncing the filter state with URL parameters to maintain bookmarking and sharing functionality
- Extract repeated filter matching logic (e.g. finding active filters) into a shared utility function to reduce duplication
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Merge changes into the release branch, introducing a new filter management system with the FilterProvider, enhancing the dataset search and filter functionalities, and updating dependencies and CI configurations. The changes also include refactoring components for better state management and user interaction, as well as updating tests to align with the new data structures.
New Features:
Enhancements:
Build:
CI:
Deployment:
Tests:
Chores: