Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12921] Fix Layers admin interface raise error #12922

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Conversation

mattiagiupponi
Copy link
Contributor

ref #12921

The new metadata editor require an id while calling the autocomplete endpoint, so we cannot switch to it.
It means that we can mantain the tkeywords in the admin interface, but without autocomplete (like we have for regions and other metadata):
image

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi added this to the 5.0.0 milestone Feb 18, 2025
@mattiagiupponi mattiagiupponi self-assigned this Feb 18, 2025
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Feb 18, 2025
@mattiagiupponi mattiagiupponi linked an issue Feb 18, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.94%. Comparing base (267ad61) to head (cc0cf35).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12922      +/-   ##
==========================================
+ Coverage   61.92%   67.94%   +6.02%     
==========================================
  Files         978      978              
  Lines       59096    59091       -5     
  Branches     6907     6907              
==========================================
+ Hits        36593    40150    +3557     
+ Misses      20929    17296    -3633     
- Partials     1574     1645      +71     

Copy link
Contributor

@giohappy giohappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattiagiupponi let's remove this field completely from the admin.

@giohappy giohappy merged commit e15b56c into master Feb 19, 2025
17 checks passed
@giohappy giohappy deleted the ISSUE_12921 branch February 19, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layers admin interface raise error
2 participants