Fix: typo in slow_fba, a bug in fast_fba

GeomScale · May 18, 2024 · f8c5e8d · f8c5e8d
1 parent c51f0a5
commit f8c5e8d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/dingo/fba.py b/dingo/fba.py
@@ -13,7 +13,7 @@
 def slow_fba(lb, ub, S, c):
     """A Python function to perform fba using scipy.optimize LP solver `linprog`
     Returns an optimal solution and its value for the following linear program:
-    min c*v, subject to,
+    max c*v, subject to,
     Sv = 0, lb <= v <= ub
 
     Keyword arguments:

diff --git a/dingo/gurobi_based_implementations.py b/dingo/gurobi_based_implementations.py
@@ -108,8 +108,8 @@ def fast_fba(lb, ub, S, c):
                     optimum_value = -model.getObjective().getValue()
                     v = model.getVars()
 
-                for i in range(n):
-                    optimum_sol.append(v[i].x)
+                    for i in range(n):
+                        optimum_sol.append(v[i].x)
 
                 optimum_sol = np.asarray(optimum_sol)