Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

191 pushes to master should trigger merges and pushes to other protected branches #244

Open
wants to merge 13 commits into
base: otakaro_digital_twin
Choose a base branch
from
Open

191 pushes to master should trigger merges and pushes to other protected branches #244

wants to merge 13 commits into from

Conversation

Martin20494
Copy link
Contributor

DESCRIPTION OF PR: Create automerge function to merge master and branch

Closes: #191

Developer Checklist

  • Make code change
  • Update tests
    • Update / create new tests
    • Ensure these tests have the expected behaviour
    • Test locally and ensure tests are passing
  • Update documentation
    • Readme
    • Docstrings
    • Comments
    • Wiki

Reviewer Checklist

  • Check new code for code smells
  • Check new tests
    • Ensure adequate coverage
    • Check for code smells within tests
  • Check if documentation needs updating
    • Readme
    • Docstrings
    • Comments
    • Wiki

@Martin20494 Martin20494 linked an issue Sep 13, 2024 that may be closed by this pull request
Pushes to master should trigger merges and pushes to other protected branches #191
Open
LukeParky
LukeParky requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@LukeParky LukeParky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work this looks like it works brilliantly. My comments about Build Documentation.yml may be difficult to fit in so focus on the other comments first, and come back to me about for some discussion around if you think the build_documentation comments are worthwhile.

.github/workflows/automerge.yml Outdated Show resolved Hide resolved
.github/workflows/automerge.yml Outdated Show resolved Hide resolved
.github/workflows/automerge.yml Outdated Show resolved Hide resolved
.github/workflows/automerge.yml Outdated Show resolved Hide resolved
.github/workflows/automerge.yml Outdated Show resolved Hide resolved
.github/workflows/automerge.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeParky LukeParky LukeParky requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pushes to master should trigger merges and pushes to other protected branches
2 participants
@Martin20494 @LukeParky