Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Avon green styling colours #304

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Conversation

LukeParky
Copy link
Member

@LukeParky LukeParky commented Nov 25, 2024

DESCRIPTION OF PR:

Uses a forked version of TerriaMap from https://github.com/GeospatialResearch/TerriaMapOtakaro
This gives a different colour styling and a Kowhaiwhai design in the brand bar element.

EDIT: After discussions with Casey we made the call to change to a design that was not using designs that are strongly tied to UC

image

Developer Checklist

  • Make code change
  • Update tests
    • Update / create new tests
    • Ensure these tests have the expected behaviour
    • Test locally and ensure tests are passing
  • Update documentation
    • Readme
    • Docstrings
    • Comments
    • Wiki

Reviewer Checklist

  • Check new code for code smells
  • Check new tests
    • Ensure adequate coverage
    • Check for code smells within tests
  • Check if documentation needs updating
    • Readme
    • Docstrings
    • Comments
    • Wiki

@LukeParky LukeParky linked an issue Nov 25, 2024 that may be closed by this pull request
@LukeParky LukeParky self-assigned this Nov 25, 2024
@LukeParky LukeParky force-pushed the 303-style-terria-map branch from 72ef777 to 6e1d45f Compare November 25, 2024 04:38
@LukeParky LukeParky assigned arpo-deer and caseyli92 and unassigned LukeParky Nov 25, 2024
@LukeParky LukeParky marked this pull request as ready for review November 25, 2024 04:45
@LukeParky
Copy link
Member Author

@arpo-deer can you please give feedback on the design

@LukeParky LukeParky force-pushed the 303-style-terria-map branch from eafc998 to 99e0238 Compare November 26, 2024 03:03
Copy link
Member

@caseyli92 caseyli92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, make sure all colours for everything are up to date and match :)

@LukeParky LukeParky force-pushed the 303-style-terria-map branch from 99e0238 to e4a2ed0 Compare November 27, 2024 01:11
@LukeParky LukeParky force-pushed the 303-style-terria-map branch from e4a2ed0 to 0e039eb Compare November 27, 2024 01:53
@LukeParky LukeParky force-pushed the 303-style-terria-map branch from 0e039eb to 20ae0b8 Compare November 27, 2024 02:42
@LukeParky LukeParky changed the title Add kowhaiwhai and red styling colours Add Avon green styling colours Nov 27, 2024
@LukeParky LukeParky requested a review from caseyli92 November 27, 2024 05:45
Copy link
Member

@caseyli92 caseyli92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work :)

@LukeParky LukeParky merged commit b3a2a92 into otakaro_digital_twin Nov 27, 2024
8 checks passed
@LukeParky LukeParky deleted the 303-style-terria-map branch November 27, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style terria map
3 participants