Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SwFacilityDischargePoint #323

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Remove SwFacilityDischargePoint #323

merged 1 commit into from
Nov 26, 2024

Conversation

Martin20494
Copy link
Contributor

DESCRIPTION OF PR: Remove SwFacilityDischargePoint because they have no data but keep SwPipeRestraint, it has data it is just too small to see

Developer Checklist

  • Make code change
  • Update tests
    • Update / create new tests
    • Ensure these tests have the expected behaviour
    • Test locally and ensure tests are passing
  • Update documentation
    • Readme
    • Docstrings
    • Comments
    • Wiki

Reviewer Checklist

  • Check new code for code smells
  • Check new tests
    • Ensure adequate coverage
    • Check for code smells within tests
  • Check if documentation needs updating
    • Readme
    • Docstrings
    • Comments
    • Wiki

@Martin20494 Martin20494 linked an issue Nov 26, 2024 that may be closed by this pull request
Data features missing from some datasets #314
Closed
@LukeParky LukeParky self-assigned this Nov 26, 2024
@LukeParky LukeParky force-pushed the 314-data-features-missing-from-some-datasets branch from 8776ee6 to 60eea3f Compare November 26, 2024 04:44
@LukeParky
Remove SwFacilityDischargePoint because there is no data but keep SwP…
a965ff1 
…ipeRestraint, it has data it is just too small to see
@LukeParky LukeParky force-pushed the 314-data-features-missing-from-some-datasets branch from 60eea3f to a965ff1 Compare November 26, 2024 04:44
@LukeParky LukeParky enabled auto-merge (squash) November 26, 2024 04:44
@LukeParky LukeParky disabled auto-merge November 26, 2024 04:45
@LukeParky LukeParky enabled auto-merge (squash) November 26, 2024 04:46
@LukeParky LukeParky merged commit 26e62d5 into otakaro_digital_twin Nov 26, 2024
5 checks passed
@LukeParky LukeParky deleted the 314-data-features-missing-from-some-datasets branch November 26, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeParky LukeParky LukeParky approved these changes

Assignees

@LukeParky LukeParky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data features missing from some datasets
2 participants
@Martin20494 @LukeParky