fix(repo): compatibility with Flutter 3.19

[mauriziopinotti]

Submit a pull request

CLA

• I have signed the Stream CLA (required).
• The code changes follow best practices
• Code changes are tested (add some information if not applicable)

Description of the pull request

Adds compatibility for Flutter 3.19, see issue #1839

[esarbanis]

Hi @mauriziopinotti thank you for opening this and keeping a close eye on the releases, please fix the pipeline errors before we can review/merge.

[mauriziopinotti]

Hi @mauriziopinotti thank you for opening this and keeping a close eye on the releases, please fix the pipeline errors before we can review/merge.

hi @esarbanis the commit message is ok now, I am not sure how to re-run the pipeline:

[esarbanis]

@mauriziopinotti I fixed this for you 🙂 it was in the title of the PR itself. I suspect the other breaks are from not updating flutter_version in our pipelines.

[yeasin50]

showBottomSheet change is necessary and works 👍

[matthewfx]

Any ETA on this one?

[mauriziopinotti]

I have fixed all warnings and lints but there are still 2 failing tests.

If a maintainer or anyone else wants to spend some time to fix them that would be appreciated, doing this in my spear time will definitely require weeks to come to an end.

[esarbanis]

@mauriziopinotti thank you for the effort you put into this PR, I will take it over, but FYI this is not that easy to drive home, as a full regression test is needed and also it just entered my pipeline ... 😓

[esarbanis]

FYI #1870 will make the stable version compatible with flutter versions >= 3.13.0 once this lands on master we will release v7.1.0

[flodaniel]

FYI #1870 will make the stable version compatible with flutter versions >= 3.13.0 once this lands on master we will release v7.1.0

7.1.0 is out, can you merge and release this now? :)

[esarbanis]

@flodaniel I will merge 7.1 to 8 and release a new beta. But out of curiosity, why are you using beta and not stable?

[mauriziopinotti]

@flodaniel I will merge 7.1 to 8 and release a new beta. But out of curiosity, why are you using beta and not stable?

In my case I temporarily switched to beta version some months ago because of updated dependencies, namely package_info_plus (stream chat stable had 4.x and I needed 5.x) and file_picker (stream chat had 5.x and I needed 6.x).

Now I'm back on the stable branch, although dependencies are outdated again (file_picker is now at 8.x and it's not supported by stream chat so I'm forcibly overriding it).

So, maybe, I'd suggest to keep dependencies as updated as possible at least on the beta branch so people living on the edge don't have to manually override them.

[esarbanis]

@mauriziopinotti thank you for your feedback, it is much appreciated. We are very careful when updating a dependency, especially a major version, as they usually come with broken changes. So, we tend to add major version updates of our dependencies to our next major version (beta), so that users are properly informed that this might introduce breaking changes.

Having said that, we are constantly in the process to identify dependencies that can be removed, so that we also remove the complexity they bring to our users.

[mauriziopinotti]

@mauriziopinotti thank you for your feedback, it is much appreciated. We are very careful when updating a dependency, especially a major version, as they usually come with broken changes. So, we tend to add major version updates of our dependencies to our next major version (beta), so that users are properly informed that this might introduce breaking changes.

Having said that, we are constantly in the process to identify dependencies that can be removed, so that we also remove the complexity they bring to our users.

Yes, this makes perfect sense: and to be honest, I think the "issue" is mostly on the file_picker side, since its maintainer bumps the major version often, even if there are no breaking changes and this causes headaches and confusion.

IMHO for you it's a safe choice to be careful about dependencies in the main branch, although maybe that requirement can be loosened in the beta branch.

[flodaniel]

@flodaniel I will merge 7.1 to 8 and release a new beta. But out of curiosity, why are you using beta and not stable?

I was on the beta due to a photo_manager dependency. I was under the impression that 7.1 is not working with flutter 3.19 but that appears to be incorrect so I have now switched to stable 7.1 :)

[deven98]

Thanks for this PR! Given that 3.22 support is now available as well, we are focusing on both versions plus some needed changes + constraints for the same in #1962. Closing this for now but thanks again for your contribution :)