Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): be lenient when calling nullable onThreadTap method #1854

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

esarbanis
Copy link
Contributor

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Be lenient on the presence of onThreadTap paramenter in BottomRow component.

Error:

I/flutter (30434): Error while fetching message: Null check operator used on a null value, #0      BottomRow.build._onThreadTap (package:stream_chat_flutter/src/message_widget/bottom_row.dart:172:27)

@esarbanis esarbanis requested a review from a team February 20, 2024 14:45
@esarbanis esarbanis force-pushed the fix/on-null-thread-tap branch 2 times, most recently from 2b05449 to 287567c Compare February 20, 2024 14:52
Brazol
Brazol previously approved these changes Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35d338e) 59.18% compared to head (f79c74d) 59.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1854      +/-   ##
==========================================
+ Coverage   59.18%   59.41%   +0.22%     
==========================================
  Files         310      310              
  Lines       17828    17828              
==========================================
+ Hits        10552    10592      +40     
+ Misses       7276     7236      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esarbanis esarbanis merged commit 7073571 into master Feb 21, 2024
16 checks passed
@esarbanis esarbanis deleted the fix/on-null-thread-tap branch February 21, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants