-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core, ui, localization): Add Poll attachment composer #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at/message-polls-apis
xsahil03x
force-pushed
the
feat/message-polls-apis
branch
from
December 9, 2024 13:54
2d429da
to
f9e7664
Compare
…at/polls-attachment-composer # Conflicts: # packages/stream_chat/lib/src/core/models/poll.dart # packages/stream_chat/lib/src/core/models/poll.g.dart # packages/stream_chat/lib/src/core/models/poll_option.dart # packages/stream_chat/lib/src/core/models/poll_option.g.dart # packages/stream_chat/lib/src/core/models/poll_vote.dart # packages/stream_chat/lib/src/core/models/poll_vote.g.dart # packages/stream_chat/lib/src/event_type.dart
xsahil03x
force-pushed
the
feat/message-polls-apis
branch
3 times, most recently
from
December 10, 2024 12:25
6ce3523
to
f9c7890
Compare
…nt-composer # Conflicts: # packages/stream_chat/lib/src/core/models/poll.dart # packages/stream_chat/lib/src/core/models/poll.g.dart # packages/stream_chat/lib/src/core/models/poll_option.dart # packages/stream_chat/lib/src/core/models/poll_option.g.dart # packages/stream_chat/lib/src/core/models/poll_vote.dart # packages/stream_chat/lib/src/core/models/poll_vote.g.dart
deven98
reviewed
Dec 11, 2024
...es/stream_chat_flutter/lib/src/message_input/attachment_picker/stream_attachment_picker.dart
Outdated
Show resolved
Hide resolved
deven98
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new features and improvements related to polls in the
stream_chat
package. Key changes include adding methods for managing polls in channels, updating poll-related models, and enhancing the user interface for creating and displaying polls.Poll Management in Channels
Channel
class to send, update, and delete polls. (packages/stream_chat/lib/src/client/channel.dart
)Poll Model Updates
_NullConst
class for handling nullable fields inPoll
andPollOption
classes. (packages/stream_chat/lib/src/core/models/poll.dart
,packages/stream_chat/lib/src/core/models/poll_option.dart
) [1] [2]enforceUniqueVote
totrue
inPoll
class. (packages/stream_chat/lib/src/core/models/poll.dart
,packages/stream_chat/lib/src/core/models/poll.g.dart
) [1] [2]toJson
methods to exclude null values forid
fields inPollOption
andPollVote
classes. (packages/stream_chat/lib/src/core/models/poll_option.g.dart
,packages/stream_chat/lib/src/core/models/poll_vote.g.dart
) [1] [2]User Interface Enhancements
StreamPollCreator
widget for creating polls within the message input attachment picker. (packages/stream_chat_flutter/lib/src/message_input/attachment_picker/options/stream_poll_creator.dart
)StreamUnreadIndicator
to useBadge
widget for displaying unread counts. (packages/stream_chat_flutter/lib/src/indicators/unread_indicator.dart
)Localization and Permission Updates
packages/stream_chat_flutter/lib/src/localization/translations.dart
) [1] [2]sendPoll
inPermissionType
class. (packages/stream_chat/lib/src/permission_type.dart
)