fix(ui): fix StreamChannel not available in various poll dialogs #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsahil03x
commented
Jan 13, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2082 +/- ##
==========================================
- Coverage 60.17% 60.15% -0.02%
==========================================
Files 372 372
Lines 22766 22773 +7
==========================================
Hits 13699 13699
- Misses 9067 9074 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a bug fix in the
stream_chat_flutterpackage, ensuring that theStreamChannelis properly available in the widget tree for various poll-related dialogs. The changes primarily involve wrapping theValueListenableBuilderin aStreamChannelwidget to provide the necessary context.Bug Fixes:
packages/stream_chat_flutter/CHANGELOG.md: Added a note about the fix forStreamChannelnot being available in the widget tree for various poll options.Poll Dialogs:
packages/stream_chat_flutter/lib/src/poll/stream_poll_comments_dialog.dart: WrappedValueListenableBuilderin aStreamChannelwidget to ensure the channel context is available. [1] [2]packages/stream_chat_flutter/lib/src/poll/stream_poll_option_votes_dialog.dart: WrappedValueListenableBuilderin aStreamChannelwidget to ensure the channel context is available. [1] [2]packages/stream_chat_flutter/lib/src/poll/stream_poll_options_dialog.dart: WrappedValueListenableBuilderin aStreamChannelwidget to ensure the channel context is available. [1] [2]packages/stream_chat_flutter/lib/src/poll/stream_poll_results_dialog.dart: WrappedValueListenableBuilderin aStreamChannelwidget to ensure the channel context is available. [1] [2]