Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(llc): allow overridding websocket baseUrl #2093

Merged
merged 4 commits into from
Jan 25, 2025
Merged

Conversation

kanat
Copy link
Contributor

@kanat kanat commented Jan 24, 2025

Ticket

Related PR

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

@kanat kanat requested a review from xsahil03x January 24, 2025 23:22
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.16%. Comparing base (7ed1709) to head (6a9a2a4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
packages/stream_chat/lib/src/ws/websocket.dart 81.81% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2093   +/-   ##
=======================================
  Coverage   60.15%   60.16%           
=======================================
  Files         372      372           
  Lines       22773    22781    +8     
=======================================
+ Hits        13699    13706    +7     
- Misses       9074     9075    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xsahil03x xsahil03x changed the title [CHA-546] override websocket baseUrl separately feat(llc): allow overridding websocket baseUrl Jan 25, 2025
Copy link
Member

@xsahil03x xsahil03x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xsahil03x xsahil03x merged commit 7576837 into master Jan 25, 2025
14 checks passed
@xsahil03x xsahil03x deleted the push/override-ws-url branch January 25, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants