Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): restructure stream svg icons #2094

Merged
merged 7 commits into from
Jan 30, 2025
Merged

Conversation

xsahil03x
Copy link
Member

@xsahil03x xsahil03x commented Jan 28, 2025

This pull request includes several changes to the stream_chat_flutter package to improve the handling of SVG icons and update asset paths. The most important changes include refactoring the StreamSvgIcon usage, updating image asset paths, and importing the correct icon files.

Improvements to SVG icon handling:

Updating image asset paths:

Correcting icon file imports:

Dark Light
image image

@xsahil03x xsahil03x changed the title feat(ui): restructure stream svg icons refactor(ui): restructure stream svg icons Jan 28, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 60.56338% with 56 lines in your changes missing coverage. Please review.

Project coverage is 59.89%. Comparing base (7ed1709) to head (d212dba).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...at_flutter/lib/src/attachment/file_attachment.dart 22.22% 7 Missing ⚠️
...am_chat_flutter/lib/src/icons/stream_svg_icon.dart 64.28% 5 Missing ⚠️
...ottom_sheets/stream_channel_info_bottom_sheet.dart 0.00% 4 Missing ⚠️
...rc/attachment/attachment_upload_state_builder.dart 25.00% 3 Missing ⚠️
...ib/src/message_input/quoting_message_top_area.dart 0.00% 3 Missing ⚠️
...chment_actions_modal/attachment_actions_modal.dart 66.66% 2 Missing ⚠️
.../attachment_picker/options/stream_file_picker.dart 0.00% 2 Missing ⚠️
...attachment_picker/options/stream_image_picker.dart 0.00% 2 Missing ⚠️
...attachment_picker/options/stream_poll_creator.dart 0.00% 2 Missing ⚠️
...attachment_picker/options/stream_video_picker.dart 0.00% 2 Missing ⚠️
... and 24 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2094      +/-   ##
==========================================
- Coverage   60.15%   59.89%   -0.26%     
==========================================
  Files         372      372              
  Lines       22773    22730      -43     
==========================================
- Hits        13699    13615      -84     
- Misses       9074     9115      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@deven98 deven98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xsahil03x xsahil03x merged commit e1ec460 into master Jan 30, 2025
13 of 14 checks passed
@xsahil03x xsahil03x deleted the refactor/stream-svg-icons branch January 30, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants