Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]Improve Error logging #645

Merged
merged 4 commits into from
Jan 31, 2025
Merged

[Enhancement]Improve Error logging #645

merged 4 commits into from
Jan 31, 2025

Conversation

ipavlidakis
Copy link
Collaborator

🎯 Goal

Provide better error logging while improving consistency and error visibility.

📝 Summary

Extending ReflectiveStingConvertible and conforming main error objects to it.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

@ipavlidakis ipavlidakis added the enhancement New feature or request label Jan 30, 2025
@ipavlidakis ipavlidakis self-assigned this Jan 30, 2025
@ipavlidakis ipavlidakis requested a review from a team as a code owner January 30, 2025 14:04
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Jan 30, 2025 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.42 MB 7.46 MB +34 KB 🟢
StreamVideoSwiftUI 2.07 MB 2.07 MB 0 KB 🟢
StreamVideoUIKit 2.21 MB 2.21 MB 0 KB 🟢
StreamWebRTC 9.85 MB 9.85 MB 0 KB 🟢

@ipavlidakis ipavlidakis force-pushed the feature/improve-error-logging branch from 3d73e42 to a21aa75 Compare January 30, 2025 16:17
martinmitrevski
martinmitrevski approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 👏

@ipavlidakis ipavlidakis merged commit f9381c5 into develop Jan 31, 2025
7 of 8 checks passed
@ipavlidakis ipavlidakis deleted the feature/improve-error-logging branch January 31, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski