Fix/notify reward audit fix #48
Open
+124
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aminlatifi
commented
Jan 21, 2025
aminlatifi
commented
- Fixes Fix minor issue on notify reward on uinpools #46
divine-comedian
requested changes
Jan 21, 2025
| require(success, 'UnipoolTokenDistributor: CALL_FAILED'); | ||
| (uint256 allocatedTokens,) = abi.decode(data, (uint256, uint256)); | ||
|
|
||
| require(allocatedTokens >= _reward, 'UnipoolTokenDistributor: NOT_ENOUGH_TOKEND_ISTRO_BALANCE'); |
There was a problem hiding this comment.
typo in revert message
| require(success, 'UnipoolTokenDistributor: CALL_FAILED'); | ||
| (uint256 allocatedTokens,) = abi.decode(data, (uint256, uint256)); | ||
|
|
||
| require(allocatedTokens >= _reward, 'UnipoolTokenDistributor: NOT_ENOUGH_TOKEND_ISTRO_BALANCE'); |
| } | ||
|
|
||
| (bool success, bytes memory data) = |
There was a problem hiding this comment.
So this function is now adding an additional check if the unipool has enough balance that is equal or greater than the amount of rewards it will distribute?
the internal variable _reward does it decrease as rewards are distributed or is it a total number of rewards it has given across its entire lifespan?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.