Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solana user profile support #1193

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Solana user profile support #1193

merged 3 commits into from
Dec 11, 2023

Conversation

aminlatifi
Copy link
Member

Save non-evm user wallet address capitalization

@aminlatifi
Copy link
Member Author

Ref Giveth/giveth-dapps-v2#3400

mohammadranjbarz
mohammadranjbarz approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@mohammadranjbarz mohammadranjbarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aminlatifi Seems good to me.
But tests haven't passed

@aminlatifi
Copy link
Member Author

Thanks @aminlatifi Seems good to me. But tests haven't passed

Thanks @mohammadranjbarz. The authentication server URL had been changed. No test action has been run since then. Pushed a commit to fix it.

CarlosQ96
CarlosQ96 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@CarlosQ96 CarlosQ96 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Amin looks good, thanks for changing urls

CarlosQ96
CarlosQ96 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@CarlosQ96 CarlosQ96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing to new urls all good!

@aminlatifi aminlatifi merged commit 0415865 into develop Dec 11, 2023
4 checks passed
@aminlatifi aminlatifi deleted the feat/solana_support branch December 11, 2023 18:22
@aminlatifi aminlatifi restored the feat/solana_support branch December 18, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosQ96 CarlosQ96 CarlosQ96 approved these changes

@mohammadranjbarz mohammadranjbarz mohammadranjbarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aminlatifi @mohammadranjbarz @CarlosQ96